[main][debug tool] enable check compressed data #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 40acc18.
…/ApplicationInsights-JS into siyu/compressCheckTool
MSNev
reviewed
Jan 14, 2025
tools/chrome-debug-extension/src/dataSources/defaultDataSource.ts
Outdated
Show resolved
Hide resolved
MSNev
reviewed
Jan 14, 2025
| _handleMessage(event, details); | ||
| } | ||
| if (details.requestBody && details.requestBody.raw) { | ||
| let gzipped = isGzip(details.requestBody.raw[0].bytes as ArrayBuffer); |
There was a problem hiding this comment.
While its good to "validate" that it's really gzipped, we should be checking the Encoding header and only attempt this check if it was reported as encoded as gzipped.
There was a problem hiding this comment.
requestHeaders is only available under onBeforeSendHeaders func
MSNev
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.