Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sustainability preview posting subscriber #27775

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix Sustainability preview posting subscriber #27775

merged 2 commits into from
Dec 13, 2024

Conversation

vlkov
Copy link
Contributor

@vlkov vlkov commented Dec 6, 2024 •
edited by github-actions bot
Loading

Summary

Change the binding preview posting codeunits using try method like in service posting

Work Item(s)

Fixes #27706

Fixes AB#559882

@vlkov vlkov requested a review from a team as a code owner December 6, 2024 11:44
@vlkov vlkov requested a review from pborring December 6, 2024 11:44
@JesperSchulz JesperSchulz added approved The issue is approved Finance GitHub request for Finance area labels Dec 6, 2024
@JesperSchulz JesperSchulz self-assigned this Dec 6, 2024
@JesperSchulz JesperSchulz added linked Issue is linked to a Azure Boards work item and removed approved The issue is approved labels Dec 6, 2024
@JesperSchulz
Copy link
Contributor

This PR was processed internally. Unsure why tests are failing here on GitHub. We will need to investigate.

@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Dec 9, 2024
@JesperSchulz
Copy link
Contributor

Fix was backported for release with 25.3 as well.

@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Dec 12, 2024
@JesperSchulz
Copy link
Contributor

Availability update: We will publish a fix for this issue in the next update for release 25.

Build ID to track: 27886.

@JesperSchulz JesperSchulz reopened this Dec 12, 2024
@JesperSchulz
Copy link
Contributor

@vlkov, could you try to pull from main? Then we'll give it another run. It should pass then!

@vlkov
Copy link
Contributor Author

vlkov commented Dec 12, 2024

@JesperSchulz merged from main

@JesperSchulz
Copy link
Contributor

@JesperSchulz merged from main

Let's run once more. Would love to merge this PR here on GitHub rather than to close it 😊

@JesperSchulz JesperSchulz enabled auto-merge (squash) December 12, 2024 14:43
@JesperSchulz
Copy link
Contributor

Sorry @vlkov, could you try to pull from main one last time? If this doesn't work, I'll force merge your PR. I just really would love our CI to come back to life!

@JesperSchulz
Copy link
Contributor

We'll force merge now 😊

@aholstrup1 aholstrup1 disabled auto-merge December 13, 2024 07:01
@aholstrup1 aholstrup1 merged commit 2ac1ba8 into microsoft:main Dec 13, 2024
6 of 8 checks passed
@JesperSchulz
Copy link
Contributor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 27743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@pborring pborring Awaiting requested review from pborring pborring is a code owner automatically assigned from microsoft/dynamics-365-business-central

Assignees

@JesperSchulz JesperSchulz

Labels
Finance GitHub request for Finance area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Sustainability subscribers broke a preview posting
4 participants
@vlkov @JesperSchulz @aholstrup1 @VladyslavxKovalchuk