[E-Document Connector] Logiq E-Document Connector #27562

tstefanovicius · 2024-10-30T08:28:24Z

E-Documents connector interface implementation between Business Central and Logiq

Work Item(s)
Fixes #27058
Fixes AB#541809

tstefanovicius · 2024-10-30T08:28:42Z

@microsoft-github-policy-service agree company="Companial"

tstefanovicius · 2024-10-30T08:34:28Z

New pull request instead of #27101

Groenbech96 · 2024-10-31T11:00:42Z

Thanks for fixing the issue.
Please move the code to EDocumentConnectors

Create app for the connector.
Create app for the test automation.

Feel free to look at Avalara as the example.

In the mean time we will start looking at the code.

Groenbech96

Some initial comments.
Overall the code is good quality and i will continue review.

Please see comment about moving to seperate app :)

Groenbech96 · 2024-11-01T08:45:41Z

Apps/W1/EDocumentsConnector/app/src/Logiq/LogiqAPIEngine.Enum.al

+
+enum 6380 "Logiq API Engine"
+{
+    Extensible = false;


Mark it as internal.

Marked as Internal

Groenbech96 · 2024-11-01T08:45:58Z

Apps/W1/EDocumentsConnector/app/src/Logiq/LogiqAPIEngine.Enum.al

@@ -0,0 +1,19 @@
+namespace Microsoft.EServices.EDocumentConnector.Logiq;
+
+enum 6380 "Logiq API Engine"


Dont prefix with Logiq

Removed prefix

Groenbech96 · 2024-11-01T08:46:24Z

Apps/W1/EDocumentsConnector/app/src/Logiq/LogiqAuth.Codeunit.al

@@ -0,0 +1,182 @@
+namespace Microsoft.EServices.EDocumentConnector.Logiq;
+
+codeunit 6380 "Logiq Auth"


Please move the code to EDocumentConnectors

Create app for the connector.
Create app for the test automation.
Feel free to look at Avalara as the example.

In the mean time we will start looking at the code.

Created connector and test apps. Moved to EDocumentConnectors folder

Groenbech96 · 2024-11-01T08:46:54Z

Apps/W1/EDocumentsConnector/app/src/Logiq/LogiqAuth.Codeunit.al

+        ResponseMessage: HttpResponseMessage;
+        AccessToken, RefreshToken : SecretText;
+        AccessTokExpires, RefreshTokExpires : DateTime;
+        AuthenticationFailedErr: Label 'Logiq authentication failed. Please check the user credentials.';


Labels needs to be on global var.

Labels moved to global var

Groenbech96 · 2024-11-01T08:47:42Z

Apps/W1/EDocumentsConnector/app/src/Logiq/LogiqAuth.Codeunit.al

+
+    internal procedure CheckUserCredentials(var LogiqConnectionUserSetup: Record "Logiq Connection User Setup")
+    var
+        NoSetupErr: Label 'No user setup found. Please fill the user setup in the Logiq Connection User Setup page.';


Labels to global var

Labels moved to global var

Groenbech96 · 2024-11-01T08:49:00Z

Apps/W1/EDocumentsConnector/app/src/Logiq/LogiqConnectionSetup.Page.al

+
+page 6380 "Logiq Connection Setup"
+{
+    Caption = 'E-Document External Connection Setup';


Different name. Use connector name

Groenbech96 · 2024-11-01T08:49:45Z

Apps/W1/EDocumentsConnector/app/src/Logiq/LogiqConnectionSetup.Table.al

+    DataClassification = CustomerContent;
+    fields
+    {
+        field(1; PK; Code[10])


20 is standard.

Changed Code 10 > 20

Added tests Added app.json files Fixes

Groenbech96 · 2024-11-22T13:11:25Z

@tstefanovicius new interfaces will break the build :)

tstefanovicius · 2024-11-22T13:30:11Z

Ahh, it was committed two days ago, will update

Set Setup tables to Internal

Groenbech96

Will continue to look later. Good changes so far!

Groenbech96 · 2024-11-26T21:22:49Z

Apps/W1/EDocumentConnectors/Logiq/app/src/APIEngine.Enum.al

@@ -0,0 +1,20 @@
+namespace Microsoft.EServices.EDocumentConnector.Logiq;


All files should contain the license comments as the first thing.

Groenbech96 · 2024-11-26T21:36:56Z

Apps/W1/EDocumentConnectors/Logiq/app/src/EDocument.PageExt.al

+    {
+        addafter(GetApproval)
+        {
+            action(UpdateStatus)


Great that we have an action. 👍 🥇

Set visibility based on if document relates to Service, and is incomming/Outgoing?
Can you change this to use the IDocumentAction interface. Then you dont have to do the manual logging you are doing. You should not do that essentially. Framework shoud.

I can see that this also checks approval. What is stauses is it checking. Do we have a more specific name?

If this is for sent documents. Can we use Approval action that already exissts?

Sent documents in Logiq system can have statuses: "received" and "processed" (which we translate to "In Progress Logiq" service status), "distributed" (translate to approved to work with the framework even thought it's not exactly the same status) and "failed" (translate to "Failed Logiq"). We could use standard approval action but if I understand correctly, the standard status logging would not recognize custom service statuses as processed or error, so the document status would always be in progress.

Added logo Updated app.jsons Added Logiq External Id field

Groenbech96 · 2024-12-04T08:32:28Z

I removed Update function. You are trying to achieve something that is already natively supported, aka Sending with async confirmation. Now code uses JQ automatically to check if document was approved (distributed) in the service.

Removed the need for page ext, and enum ext, because of above.
Fixed tests to run on the JQ instead of manual actions.

tstefanovicius · 2024-12-13T13:14:24Z

Changes look good to me 👍

microsoft#27101 Changes with merged main

dc10695

tstefanovicius requested review from Groenbech96, WaelAbuSeada and aholstrup1 as code owners October 30, 2024 08:28

github-actions bot added the linked Issue is linked to a Azure Boards work item label Oct 30, 2024

tstefanovicius changed the title ~~[E-Document Connector] Logiq E-Document Connector #27101~~ [E-Document Connector] Logiq E-Document Connector Oct 30, 2024

Added DataClassification to user fields

f2827a9

JesperSchulz added the Integration GitHub request for Integration area label Oct 31, 2024

Groenbech96 requested changes Nov 1, 2024

View reviewed changes

Moved objects to new folder

8bfe6c9

Added tests Added app.json files Fixes

tstefanovicius requested a review from a team as a code owner November 22, 2024 12:54

Updated with E-document Interfaces v2 microsoft#27058

42f17bd

Set Setup tables to Internal

Groenbech96 requested changes Nov 26, 2024

View reviewed changes

JesperSchulz assigned Groenbech96 Nov 27, 2024

tstefanovicius and others added 3 commits November 27, 2024 16:17

Added license text

8169987

Added logo Updated app.jsons Added Logiq External Id field

Added MockService files

60be83e

Use GetResponse as UpdateStatus is just async confirmation

c24ddcd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[E-Document Connector] Logiq E-Document Connector #27562

[E-Document Connector] Logiq E-Document Connector #27562

tstefanovicius commented Oct 30, 2024 •

edited by github-actions bot

Loading

tstefanovicius commented Oct 30, 2024

tstefanovicius commented Oct 30, 2024

Groenbech96 commented Oct 31, 2024

Groenbech96 left a comment

Groenbech96 Nov 1, 2024

tstefanovicius Nov 22, 2024

Groenbech96 Nov 1, 2024

tstefanovicius Nov 22, 2024

Groenbech96 Nov 1, 2024

tstefanovicius Nov 22, 2024

Groenbech96 Nov 1, 2024

tstefanovicius Nov 22, 2024

Groenbech96 Nov 1, 2024

tstefanovicius Nov 22, 2024

Groenbech96 Nov 1, 2024

tstefanovicius Nov 22, 2024

Groenbech96 Nov 1, 2024

tstefanovicius Nov 22, 2024

Groenbech96 commented Nov 22, 2024

tstefanovicius commented Nov 22, 2024 •

edited

Loading

Groenbech96 left a comment

Groenbech96 Nov 26, 2024

Groenbech96 Nov 26, 2024

Groenbech96 Nov 26, 2024

AdeleStankeviciute Nov 27, 2024

Groenbech96 commented Dec 4, 2024

tstefanovicius commented Dec 13, 2024

		@@ -0,0 +1,19 @@
		namespace Microsoft.EServices.EDocumentConnector.Logiq;

		enum 6380 "Logiq API Engine"

		@@ -0,0 +1,182 @@
		namespace Microsoft.EServices.EDocumentConnector.Logiq;

		codeunit 6380 "Logiq Auth"

		@@ -0,0 +1,20 @@
		namespace Microsoft.EServices.EDocumentConnector.Logiq;

[E-Document Connector] Logiq E-Document Connector #27562

Are you sure you want to change the base?

[E-Document Connector] Logiq E-Document Connector #27562

Conversation

tstefanovicius commented Oct 30, 2024 • edited by github-actions bot Loading

tstefanovicius commented Oct 30, 2024

tstefanovicius commented Oct 30, 2024

Groenbech96 commented Oct 31, 2024

Groenbech96 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Groenbech96 commented Nov 22, 2024

tstefanovicius commented Nov 22, 2024 • edited Loading

Groenbech96 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Groenbech96 commented Dec 4, 2024

tstefanovicius commented Dec 13, 2024

tstefanovicius commented Oct 30, 2024 •

edited by github-actions bot

Loading

tstefanovicius commented Nov 22, 2024 •

edited

Loading