-
Notifications
You must be signed in to change notification settings - Fork 625
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GP - Enhancements to Payment Terms creation, visibility of unposted b…
…atches, and Migration Log (#25831) This PR enhances the GP migration by hardening the code around Payment Terms creation, adds visibility of unposted batches, and a new Migration Log. ### Payment Terms This change hardens the code around Payment Term creation. It also includes an integration event so that a failing Payment Term could be created by a PTE if needed. ### Migration Log This change also includes a migration log. A Factbox tile is added to the Cloud Migration Management page that will show the user when a non-error action was taken by the migration app, and they should be made aware of it. Currently, these are the scenarios that are now logged: - The Payment Term was handled by 3rd party code. - Skipped creating an Account because there isn't an account number. - Skipped creating a PO because the Vendor has not been migrated. ### Unposted Batches A Factbox tile is added to the Cloud Migration Management page that shows the number of unposted batches. Fixes [AB#499261](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/499261) --------- Co-authored-by: jaymckinney <[email protected]>
- Loading branch information
1 parent
3ec0ce7
commit e4aa3da
Showing
21 changed files
with
1,616 additions
and
73 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 119 additions & 0 deletions
119
Apps/W1/HybridGP/app/src/Migration/Support/GPPaymentTerms.Page.al
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| namespace Microsoft.DataMigration.GP; | ||
|
|
||
| page 40134 "GP Payment Terms" | ||
| { | ||
| ApplicationArea = All; | ||
| Caption = 'GP Payment Terms'; | ||
| PageType = Worksheet; | ||
| SourceTable = "GP Payment Terms"; | ||
| UsageCategory = Lists; | ||
| InsertAllowed = false; | ||
| DeleteAllowed = false; | ||
| Editable = true; | ||
|
|
||
| layout | ||
| { | ||
| area(content) | ||
| { | ||
| repeater(General) | ||
| { | ||
| field(DateFormulaIsValid; DateFormulaIsValid) | ||
| { | ||
| Caption = 'Valid Date Formula'; | ||
| ToolTip = 'Indicates if the resulting date formula is valid.'; | ||
| Editable = false; | ||
| } | ||
| field(CalculatedDateFormula; CalculatedDateFormulaTxt) | ||
| { | ||
| Caption = 'Calculated Date Formula'; | ||
| ToolTip = 'Calculated Date Formula'; | ||
| Editable = false; | ||
| Style = Unfavorable; | ||
| StyleExpr = not DateFormulaIsValid; | ||
| } | ||
| field(PYMTRMID; Rec.PYMTRMID) | ||
| { | ||
| ToolTip = 'Specifies the value of the Payment Terms ID field.'; | ||
| } | ||
| field(DUETYPE; Rec.DUETYPE) | ||
| { | ||
| ToolTip = 'Specifies the value of the Due Type field.'; | ||
| } | ||
| field(DUEDTDS; Rec.DUEDTDS) | ||
| { | ||
| ToolTip = 'Specifies the value of the Due Date/Days field.'; | ||
| } | ||
| field(DISCTYPE; Rec.DISCTYPE) | ||
| { | ||
| ToolTip = 'Specifies the value of the Discount Type field.'; | ||
| } | ||
| field(DISCDTDS; Rec.DISCDTDS) | ||
| { | ||
| ToolTip = 'Specifies the value of the Discount Date/Days field.'; | ||
| } | ||
| field(DSCLCTYP; Rec.DSCLCTYP) | ||
| { | ||
| ToolTip = 'Specifies the value of the Discount Calculate Type field.'; | ||
| } | ||
| field(DSCPCTAM; Rec.DSCPCTAM) | ||
| { | ||
| ToolTip = 'Specifies the value of the Discount Percent Amount field.'; | ||
| } | ||
| field(TAX; Rec.TAX) | ||
| { | ||
| ToolTip = 'Specifies the value of the Tax field.'; | ||
| } | ||
| field(CBUVATMD; Rec.CBUVATMD) | ||
| { | ||
| ToolTip = 'Specifies the value of the CB_Use_VAT_Mode field.'; | ||
| } | ||
| field(USEGRPER; Rec.USEGRPER) | ||
| { | ||
| ToolTip = 'Specifies the value of the Use Grace Periods field.'; | ||
| } | ||
| field(CalculateDateFrom; Rec.CalculateDateFrom) | ||
| { | ||
| ToolTip = 'Specifies the value of the Calculate Date From field.'; | ||
| } | ||
| field(CalculateDateFromDays; Rec.CalculateDateFromDays) | ||
| { | ||
| ToolTip = 'Specifies the value of the Calculate Date From Days field.'; | ||
| } | ||
| field(DueMonth; Rec.DueMonth) | ||
| { | ||
| ToolTip = 'Specifies the value of the Due Month field.'; | ||
| } | ||
| field(DiscountMonth; Rec.DiscountMonth) | ||
| { | ||
| ToolTip = 'Specifies the value of the Discount Month field.'; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| trigger OnAfterGetRecord() | ||
| begin | ||
| UpdateRecordStatus(); | ||
| end; | ||
|
|
||
|
|
||
| trigger OnAfterGetCurrRecord() | ||
| begin | ||
| UpdateRecordStatus(); | ||
| end; | ||
|
|
||
| trigger OnModifyRecord(): Boolean | ||
| begin | ||
| UpdateRecordStatus(); | ||
| exit(true); | ||
| end; | ||
|
|
||
| local procedure UpdateRecordStatus() | ||
| begin | ||
| DateFormulaIsValid := Rec.GetCalculatedDateForumla(CalculatedDateFormulaTxt); | ||
| end; | ||
|
|
||
| var | ||
| CalculatedDateFormulaTxt: Text[50]; | ||
| DateFormulaIsValid: Boolean; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.