This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Special-case display of "LSTM" name #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of #143 Eventually we plan to change to a standard LSTM formulation
| # https://github.com/awf/ADBench/issues/143 | ||
| def objective_display_name(objective): | ||
| if objective.upper() == "LSTM": | ||
| return "D-LSTM" |
There was a problem hiding this comment.
What does the "D" mean?
There was a problem hiding this comment.
What about using the whole word? I.e. "DIAGONAL-LSTM" or even "LSTM (diagonal)"? I think this would be more informative
|
I'm keen on D-LSTM, we could also use IndyLSTM as per recent Google paper, but this was coded before that.
Sent on a mobile device, please excuse brevity and typos. I'll generally try to follow up when I get to a keyboard.
|
awf
approved these changes
Nov 4, 2019
|
Yes, let's just go with D-LSTM for now. It's easy enough to change it again later if we need. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of #143
Eventually we plan to change to a standard LSTM formulation