-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice.
docs/python/Modules.md
Outdated
Returns an object of the class `<Objective>Output` contains calculated values. | ||
Such classes are defined int the files `<Objective>Data.py`. | ||
|
||
4. Do not forget to add your module to the global runner script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "global runner" do you mean run-all.ps1
? If so could you say so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be a reference to section describes what the global runner is (from Architecture.md). So, what do you think about the new version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to write about adding CMakeLists and python requirements for new modules.
E.g.
- Add the following line to
/src/python/modules/CMakeLists.txt
:
add_subdirectory ("<ModuleName>")
- Add to a new module directory
requirements.txt
with python requirements of a new module, e.g.
scipy>=1.3.1 setuptools>=41.0.0
CMakeLists.txt
with something like following
This command install required pip packages on configure stage of CMake.project(<ModuleName>) execute_process( COMMAND ${Python3_EXECUTABLE} "-m" "pip" "install" "-r" "${CMAKE_CURRENT_SOURCE_DIR}/requirements.txt" )
@mikhailnikolaev if you think that adding python requirements is beyond of the scope of module documentation then I should add it to docker docs. |
Actually, I think that this stuff is about Docker, not about the Python modules. So, maybe, it is more proper to add it in a Docker docs |
Okay, I had doubts about this, I will do so. |
I disagree. First, this is about fetching dependencies as a part of CMake configuration/build. Second, this is supposed to be a guide on adding a new python module to ADBench. So, as a developer I would expect, that following steps listed here should be enough to do so. But without CMakeLists that won't be the case. So, I suggest, adding Ilia's paragraph to this doc. |
c15376a
to
d1873bd
Compare
Documentation about adding and testing Python modules is added.
Note: reference to global runner documentation from the file
/docs/python/Modules.md
is currently broken, because such a documentation is in the PR #153