Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new Gradle Shadow plugin #2618

Open
wants to merge 2 commits into
base: 4.7.x
Choose a base branch
from

Conversation

timyates
Copy link
Contributor

Previously this plugin was developed by johnrengelman and published under the ID com.github.johnrengelman.shadow before maintenance was transferred to the GradleUp organization to ensure future development

Functionally it's identical, but it doesn't have deprecation warnings like the old one started having

https://github.com/GradleUp/shadow
https://plugins.gradle.org/plugin/com.gradleup.shadow
https://gradleup.com/shadow/

Previously this plugin was developed by @johnrengelman and published under the ID com.github.johnrengelman.shadow before maintenance was transferred to the GradleUp organization to ensure future development

Functionally it's identical, but it doesn't have deprecation warnings like the old one started having
@graemerocher graemerocher requested a review from melix September 20, 2024 08:49
@timyates
Copy link
Contributor Author

timyates commented Sep 20, 2024

Seems to be failing on a TestContainers/SQLServer issue which I don't believe is of my doing 😉

@radovanradic
Copy link
Contributor

Seems to be failing on a TestContainers/SQLServer issue which I don't believe is of my doing 😉

Yes, it started failing for other projects as well. For sql and data we used different image image-name: mcr.microsoft.com/mssql/server:2022-latest and it worked.

@radovanradic
Copy link
Contributor

Yes, unless there is a way to override (temporary solution) in application-test.yml or via @Property until test-resources is changed.

Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a reasonable change, however I think we should probably go into the Gradle plugin and make sure we change it there too, at least in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants