Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added graalvm native tests #2006

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Added graalvm native tests #2006

merged 5 commits into from
Aug 16, 2023

Conversation

msupic
Copy link
Contributor

@msupic msupic commented Aug 9, 2023

@graemerocher @sdelamo - I added test-suite-graal module which contains native tests that cover metadata from the following files:

I am not sure how to run those tests in GitHub since the micronaut-starter workflows are different comparing to other micronaut projects. Should I create a new github workflow or try to add new tests to one of the existing workflows?

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, create a new workflow file which run these native tests

test-suite-graal/build.gradle Show resolved Hide resolved
test-suite-graal/build.gradle Show resolved Hide resolved
test-suite-graal/build.gradle Outdated Show resolved Hide resolved
test-suite-graal/build.gradle Outdated Show resolved Hide resolved
@msupic
Copy link
Contributor Author

msupic commented Aug 15, 2023

Please, create a new workflow file which run these native tests

I added two graalvm workflows, one for latest graalvm and another one for dev graalvm like we have in other micronaut projects. In other micronaut projects we use the build-matrix github action to create a matrix of modules for which native tests can be executed, but in this project we need to use hardcoded matrix of modules because of the following issue: #2010

@sdelamo sdelamo merged commit d95b944 into 4.0.x Aug 16, 2023
@sdelamo sdelamo deleted the native-tests branch August 16, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants