Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Updating the webpack version #36

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

VadimZvf
Copy link
Contributor

Migration from webpack 4 to 5th version.

Webpack 4 doesn't work well with node v20.
The dev mode fails with this error:
Screenshot 2024-08-17 at 14 01 16

The error doesn't appear after I update the webpack version

Migration from webpack 4 to 5th version
Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-json-view ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 8:04pm

@Kikobeats
Copy link
Member

Kikobeats commented Sep 11, 2024

Thanks for all your PRs. For reasons I don't know I didn't see the notifications for this repo.

Can you check test failing? 🙏

The latest version has esm module type
@VadimZvf
Copy link
Contributor Author

Thanks for all your PRs. For reasons I don't know I didn't see the notifications for this repo.

Can you check test failing? 🙏

Ouch... I'm sorry, I missed that the react-base16-styling package is using the new ESM module type.
The simplest fix will be a downgrading to the previous version, which is using CJS.

@VadimZvf
Copy link
Contributor Author

Tests are still red. But it's an another problem, which exists in the master branch too. I mean, it's not directly related to this PR.
The fix will be here - #38

@Kikobeats Kikobeats merged commit 7cdb50d into microlinkhq:master Sep 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants