🔧 Fixing the demo build #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Screen.Recording.2024-08-17.at.12.44.05.movAn example of the fix |
We were trying to spead a null value
Using react 16
Rebuilding the demo
Kikobeats
force-pushed
the
VadimZvf/fixing-demo-build
branch
from
b76fca7 to
45ea957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo doesn't work.
If we run the
npm run build:democommand and if we open the resulting demo in the browser, we get a blank page with an error.It doesn't work because:
forwardRefyet. It was introduced in React 16.3 - https://github.com/facebook/react/blob/main/CHANGELOG.md#react-17In this PR I'm fixing the demo build.