-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA functionality including offline mode (featured flagged) #1170
Conversation
Preview build will be at |
Does that mean everyone pays the cost of every language now? Before interactivity or after/in the background? |
Edit: This has now been resolved by using a mixture of precaching for our fallback language (English) and runtime caching for all other languages. |
Cache at runtime instead.
This means we won't show it when initially loading the app
I think this might not amount to much
We'll find another way
Use staging sim on this branch as it now has service worker support.
I'll merge this tomorrow when I'm more available for any fallout. |
This isn't working in practice as we used scoped service workers but the scope is /v/beta/ but typically access is at /v/beta for staging/production. Ideally we wouldn't redirect to the less pretty URLs. We could register against a slashless scope by adding a header. It's a prefix match so that's a bit awkward, e.g. /v/3 would also match /v/31 and /v/beta would match /v/betamax. The former seems worth some consideration. Alternatively we just have one and accept the extra reload when switching between versions. |
We did this and it now seems to be working. Still behind the flag you need to set in localStorage. |
Notable behaviours:
There are two levels of feature gating:
localStorage.setItem("flags", "pwa")
for now if you want to test an actual PWA install. We'll default that flag on to release to the beta after building more confidence internally.