-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dns_nameserver
option for mx checking
#230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just have some feedback!
Co-authored-by: Micke Lisinge <[email protected]>
Co-authored-by: Micke Lisinge <[email protected]>
Co-authored-by: Micke Lisinge <[email protected]>
…add-dns-nameserver-option
Review comments resolved |
@timkrins great! Seems like you have some failing tests still! |
Ensuring the timeout test pass is an interesting one - the DNS response was too quick in CI to hit the timeout, but did hit the timeout locally. My new solution to fail the DNS resolution in time seems to be a bit 'hacky'... As long as the DNS server doesn't respond in less than The only other way to cause a timeout might be to start a socket on a thread that does not reply (this is how it is done in the |
I've pushed 5.2.0 to rubygems. Thanks! |
Adds an option for easily customising the DNS resolver that is used for checking A and MX records.
If no option is given, it will use all current defaults.