Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to configure multiple IdPs #101

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

smbader
Copy link
Contributor

@smbader smbader commented Aug 13, 2024

This request is to modify the plugin so that multiple IdPs can be configured and used simultaneously. A new tab in the Shibboleth settings named "Identity Providers" will allow new providers to be added with the settings listed below.

Per-IdP settings:

  • New field: IdP short code (A couple of letters so that we can provide direct links.)
  • New field: entityId (The entityID is the public URI for an Identity Provider.)
  • Password Change URL (If this option is set, Shibboleth users will see a "change password" link on their profile page directing them to this URL.)
  • Password Reset URL (If this option is set, wp-login.php will send ALL users here to reset their password.)
  • Button Text (Set the text of the button that appears on the wp-login.php page. This will be used to differentiate between IdPs)

Fixes #93

@jrchamp
Copy link
Collaborator

jrchamp commented Aug 13, 2024

Thank you @smbader! This looks amazing.

I'm not sure why the CodeSniffer is trying to apply WordPress PHP rules to .js files. Maybe that's something they changed in a newer version of their eslint rules. I'll take a look into that.

Not to self - in case we should be running ESLint manually, it might look something like this:

    - name: Run ESLint
      run: yarn
      run: eslint . --ext .js

Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful! I was able to fix the JavaScript spacing issues so the automated checks pass now.

@jrchamp jrchamp merged commit eada385 into michaelryanmcneill:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple IdP Support
2 participants