Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make token to optional #250

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Make token to optional #250

merged 1 commit into from
Dec 7, 2023

Conversation

134130
Copy link

@134130 134130 commented Dec 7, 2023

  • Simple change : make input token optional. If it not given, use ${{ github.token }} default.
  • NOTE: Not changing src/action.ts's core.getInput('token', {required: true}).

@134130 134130 requested a review from mi-kas as a code owner December 7, 2023 04:57
@mi-kas
Copy link
Owner

mi-kas commented Dec 7, 2023

@134130 Nice improvement, thanks for your contribution 🙏

@mi-kas mi-kas merged commit 23a5213 into mi-kas:main Dec 7, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mi-kas mi-kas Awaiting requested review from mi-kas mi-kas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@134130 @mi-kas @cooper-oh