Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_snr() #329

Merged
merged 6 commits into from
May 12, 2024
Merged

Add min_snr() #329

merged 6 commits into from
May 12, 2024

Conversation

mhostetter
Copy link
Owner

Fixes #316

@mhostetter mhostetter added the detection Related to detectors and detection performance label May 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

Attention: Patch coverage is 35.48387% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 78.57%. Comparing base (9de5494) to head (b4e5d6a).

Files Patch % Lines
src/sdr/_detection/_theory.py 35.48% 20 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/0.0.x     #329      +/-   ##
=================================================
- Coverage          78.98%   78.57%   -0.41%     
=================================================
  Files                 59       59              
  Lines               3645     3669      +24     
=================================================
+ Hits                2879     2883       +4     
- Misses               766      786      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Prevent random test failures. This way I don't need to increase the sample size.
@mhostetter mhostetter merged commit 560d8da into release/0.0.x May 12, 2024
26 checks passed
@mhostetter mhostetter deleted the mhostetter/issue316 branch May 12, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detection Related to detectors and detection performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants