Phoenix 1.5 #98
Open
Phoenix 1.5 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be have CI ran again, since it failed with a weird error on telemetry. I branched and did almost the same changes as this and my local tests pass (some mix packages may be a little more current in my fork). |
|
This looks like a good candidate to fix #97. Any chance to get this merged? A lot of people have moved to Phoenix 1.5, so it would be greatly beneficial. Any way we can help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use with the latest Phoenix, needed to update the dependencies.
use Phoenix.ConnTestis deprecated.The HTML "AST" generated by the latest Phoenix HTML is different than previous, so had to change the tests, but confirm it worked. Not sure how you'd support multiple versions with these changes?