Add custom link function

[minibikini]

Adds a new :link_fun option to set the link function. Defaults to Phoenix.HTML.link/2.

This will allow to use Scrivener with Phoenix LiveView which has own link generation function for "live navigation".

I've replaced some common arguments with page_opts map and now not sure it was needed :) If you don't like it I'll try to turn it back.

P.S. I've been using Scrivener for years! Such a handy library, thank you!

[feliperenan]

Hi 👋

We are also using Scrivener here & Live View. Comparing with another solution I'd rather this one since it's more flexible - as far as I understood we could even define live_link as default. But both are good IMO and it's up to the maintainers to decide 😅.

What I may add here is that I tested both and they worked well in our application. Just want to know if there are plans to move forward with Live View support and if so, what else we can do to help with that 😄.

Thanks 🙌

[mgwidmann]

This looks fine to me. I don't have an application to try it out in other than the unit tests, can anyone confirm this branch is backwards compatible against a real application?

[mcrumm]

@mgwidmann 👍 confirmed backwards compatible, and the link override looks good. I look forward to seeing this land!

[speeddragon]

I think this should be merged and created a new release.

[arfl]

Any news on this?

[jrissler]

Tested this today - worked great here 😃

[ssbb]

@mgwidmann We using this branch for both normal pagination and LV-based. Works great. It would be cool if you can merge this.

[polmiro]

Tested with my application and worked perfectly, still pointing to the forked version though. Looking forward to see it merged 🍻

[jrissler]

@mgwidmann what would it take to get some of these open PR's merged in?