Skip to content

Commit

Permalink
Build: Fix unresolved jQuery reference in finalPropName
Browse files Browse the repository at this point in the history
Also, prevent further similar breakages by changing our ESLint configuration
to disallow relying on a global jQuery object in AMD modules.

Fixes jquerygh-4358
Closes jquerygh-4361
  • Loading branch information
mgol authored Apr 17, 2019
1 parent cf9fe0f commit 8740305
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
11 changes: 8 additions & 3 deletions src/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@

"extends": "../.eslintrc-browser.json",

"globals": {
"jQuery": true
}
"overrides": [
{
"files": "wrapper.js",
"globals": {
"jQuery": false
}
}
]
}
5 changes: 4 additions & 1 deletion src/css/finalPropName.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
define( [ "../var/document" ], function( document ) {
define( [
"../var/document",
"../core"
], function( document, jQuery ) {

"use strict";

Expand Down

0 comments on commit 8740305

Please sign in to comment.