WIP: Autoversion #24
Closed
WIP: Autoversion #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestions welcome :) |
loial
force-pushed
the
feature-autoversion
branch
from
8d6eae0 to
cae70c4
Compare
|
I've merged https://github.com/mgejke/asyncsector/pull/14 and published a new version of asyncsector(0.2.1) on pip. Will try to have a look at this later. |
|
Thanks, the changes from this PR is in the master branch now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with mgejke/asyncsector#14 this will allow for setting version to 'auto' in config, and will then fetch the version code for use in the API requests.
Currently does this check during (every) init. Maybe we should do a single fetch (AsyncSector.getapiversion) and store as a state, or some kind of variable, and only do another fetch when an update fails with INVALID VERSION...
Also I believe the first commit, the async init, does not break the current functioninality, but this might need some more testing...
Some discussion in #23 and mgejke/asyncsector#12
Oh, and until mgejke/asyncsector#14 gets merged, i do testing in loial/hass-sectoralarm@feature-autoversion-test (changing asyncsector requirement to 'https://github.com/loial/asyncsector/archive/feature-autoversion.zip#asyncsector==0.2.0' )