fix 968 by removing references to black and white lists #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisvmedia
reviewed
Feb 3, 2024
README.md
Outdated
| @@ -477,7 +477,7 @@ List of all available rules. The rules ported from `golint` are left unchanged a | |||
| | [`exported`](./RULES_DESCRIPTIONS.md#exported) | []string | Naming and commenting conventions on exported symbols. | yes | no | | |||
| | [`if-return`](./RULES_DESCRIPTIONS.md#if-return) | n/a | Redundant if when returning an error. | no | no | | |||
| | [`increment-decrement`](./RULES_DESCRIPTIONS.md#increment-decrement) | n/a | Use `i++` and `i--` instead of `i += 1` and `i -= 1`. | yes | no | | |||
| | [`var-naming`](./RULES_DESCRIPTIONS.md#var-naming) | whitelist & blacklist of initialisms | Naming rules. | yes | no | | |||
| | [`var-naming`](./RULES_DESCRIPTIONS.md#var-naming) | allow-list & blocklist of initialisms | Naming rules. | yes | no | | |||
There was a problem hiding this comment.
Shouldn't it be allowlist to be consistent with blocklist? I googled a little bit, it seems to be pretty common to use it as a single word.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes public identifiers of rules and parameters that use the words black or white.
Backward compatibility (with previous configurations) is ensured by mapping old names into new ones.
Closes #968