unhandled-error: use full function name in error message #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgechev
approved these changes
Jan 8, 2024
mfederowicz
pushed a commit
to mfederowicz/revive
that referenced
this pull request
Jan 14, 2024
* update tests * Update testdata/unhandled-error-w-ignorelist.go * Update testdata/unhandled-error-w-ignorelist.go --------- Co-authored-by: Denis Voytyuk <[email protected]>
|
Thank you for implemeting this, it would help a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the error message used by the
unhandled-errorrule to usethe full function name. The full function name matches the name used to
evaluate ignored functions in the configuration, therefore it's friendlier to
users to wish to configure an exlusion based on an error message.
The error message is sufficiently covered by existing tests, which are updated
in this PR.
Closes: #961