Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: rename unused parameters and receivers to _ #907

Merged

Conversation

mfederowicz
Copy link
Contributor

PR related with #904

all unused functions parameters and receivers have been replaced with undersorce (_) sign to supress warnings. Maybe there is more elegant way to do this, but I dont want to remove parameters declaration

test command: revive -config ~/revive.toml -formatter stylish {test,rule,revivelib}

config:

ignoreGeneratedHeader = false
severity = "warning"
confidence = 0.8
errorCode = 0
warningCode = 0

[rule.unused-parameter]
[rule.unused-receiver]

@chavacava chavacava merged commit 70ceb1c into mgechev:master Sep 24, 2023
4 checks passed
@chavacava
Copy link
Collaborator

Thank you @mfederowicz !

@mfederowicz mfederowicz deleted the code-cleanup-unused-parameters-receivers branch October 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants