Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for enforce-map-style rule #895

Merged
merged 10 commits into from
Sep 17, 2023
Merged

feat: add support for enforce-map-style rule #895

merged 10 commits into from
Sep 17, 2023

Conversation

denisvmedia
Copy link
Collaborator

closes #892

@denisvmedia denisvmedia force-pushed the feature/enforce-map-style branch from fe74add to 1ba22f3 Compare September 16, 2023 14:52
denisvmedia
denisvmedia commented Sep 16, 2023
View reviewed changes
RULES_DESCRIPTIONS.md Outdated Show resolved Hide resolved
@denisvmedia
Copy link
Collaborator Author

denisvmedia commented Sep 16, 2023 •
edited
Loading

I checked using kubernetes repo. It seems there is no consistency - it is noisy for both make and literal settings. So, I decided to have any as a default (basically, the linter won't work if any is set). This should prevent issues when people run revive with all linters enabled by default.

@chavacava chavacava merged commit 356e667 into mgechev:master Sep 17, 2023
4 checks passed
@denisvmedia denisvmedia deleted the feature/enforce-map-style branch September 17, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linter rule to check the consistency of make(map[type]type) vs empty map[type]type{}
2 participants
@denisvmedia @chavacava