Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ast_utils.FuncSignatureIs panics with types names other than ast.Ident #1174

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

chavacava
Copy link
Collaborator

Fixes panic of ast_utils.FuncSignatureIs with type names of types other than ast.Ident (ast.SelectorExpression, ast.StarExpression)

The bug makes revive panic if the code under analysis has a method named Less, Len, or Swap with parameters of types represented as ast.SelectorExpression or ast.StarExpression in the AST.

@chavacava chavacava merged commit 24a9325 into master Dec 7, 2024
5 checks passed
@denisvmedia denisvmedia deleted the fix/funcsignatureis-panic branch December 7, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant