refactor: reduce indentation for AddConstantRule.configure #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavacava
reviewed
Nov 16, 2024
chavacava
reviewed
Nov 16, 2024
chavacava
reviewed
Nov 16, 2024
alexandear
force-pushed
the
refactor/add-constant-configure
branch
from
16754b0 to
73d18b8
Compare
alexandear
force-pushed
the
refactor/add-constant-configure
branch
from
73d18b8 to
ec20e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR simplifies the implementation of the
AddConstantRule.configurefunction for the case when no arguments are passed. Additionally, it adds a test to prove that nothing is broken.