Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next phase of refactoring from black and white to block and allow #968

Closed
mfederowicz opened this issue Jan 29, 2024 · 2 comments · Fixed by #969
Closed

next phase of refactoring from black and white to block and allow #968

mfederowicz opened this issue Jan 29, 2024 · 2 comments · Fixed by #969

Comments

@mfederowicz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I want to open discussion about next phase of refactoring our codebase to more appropriate version of black and wihite to block and allow. First part of chages where made in issue #946

In this phase we want to remove definitely

Whitelist https://github.com/mgechev/revive/search?q=whitelist
Blacklist https://github.com/mgechev/revive/search?q=blacklist

in case whitelist it is not that dificult, but with blacklist we have one rule and some tests

any ideas/propositions how to make breaking changes related with this in the most elegant way @chavacava, @denisvmedia and any other contributors?

ps. of course we can remove old instances of ImportsBlacklistRule, but i dont remember any of issue related with breaking changes in this project

ps2. what is procedure of releasing new version (some additional steps: tests), because as I remember with last version v1.3.5 there were some problems?

@denisvmedia
Copy link
Collaborator

I think, we can have an alias for the rule name. Keeping the original name deprecated but supported as an alias for the next n releases. The output text can be changed now. Some systems can be affected, if they rely on the text wording, but they should be really few to my prediction.

Cc @chavacava wdyt?

@mfederowicz
Copy link
Contributor Author

interesting docs to read: https://go.dev/talks/2016/refactor.article

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants