cleanup functions declarations

mgechev · Dec 24, 2023 · d1ceb23 · d1ceb23
1 parent 24df8df
commit d1ceb23
Show file tree

Hide file tree

Showing 43 changed files with 90 additions and 90 deletions.
diff --git a/rule/function-length.go b/rule/function-length.go
@@ -49,14 +49,14 @@ func (r *FunctionLength) Apply(file *lint.File, arguments lint.Arguments) []lint
 }
 
 // Name returns the rule name.
-func (*FunctionLength) Name() string {
+func (r *FunctionLength) Name() string {
 	return "function-length"
 }
 
 const defaultFuncStmtsLimit = 50
 const defaultFuncLinesLimit = 75
 
-func (*FunctionLength) parseArguments(arguments lint.Arguments) (maxStmt, maxLines int64) {
+func (r *FunctionLength) parseArguments(arguments lint.Arguments) (maxStmt, maxLines int64) {
 	if len(arguments) == 0 {
 		return defaultFuncStmtsLimit, defaultFuncLinesLimit
 	}

diff --git a/rule/function-result-limit.go b/rule/function-result-limit.go
@@ -54,7 +54,7 @@ func (r *FunctionResultsLimitRule) Apply(file *lint.File, arguments lint.Argumen
 }
 
 // Name returns the rule name.
-func (*FunctionResultsLimitRule) Name() string {
+func (r *FunctionResultsLimitRule) Name() string {
 	return "function-result-limit"
 }
 

diff --git a/rule/get-return.go b/rule/get-return.go
@@ -12,7 +12,7 @@ import (
 type GetReturnRule struct{}
 
 // Apply applies the rule to given file.
-func (*GetReturnRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *GetReturnRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -25,7 +25,7 @@ func (*GetReturnRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 }
 
 // Name returns the rule name.
-func (*GetReturnRule) Name() string {
+func (r *GetReturnRule) Name() string {
 	return "get-return"
 }
 

diff --git a/rule/identical-branches.go b/rule/identical-branches.go
@@ -10,7 +10,7 @@ import (
 type IdenticalBranchesRule struct{}
 
 // Apply applies the rule to given file.
-func (*IdenticalBranchesRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *IdenticalBranchesRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -24,7 +24,7 @@ func (*IdenticalBranchesRule) Apply(file *lint.File, _ lint.Arguments) []lint.Fa
 }
 
 // Name returns the rule name.
-func (*IdenticalBranchesRule) Name() string {
+func (r *IdenticalBranchesRule) Name() string {
 	return "identical-branches"
 }
 
@@ -57,7 +57,7 @@ func (w *lintIdenticalBranches) Visit(node ast.Node) ast.Visitor {
 	return w
 }
 
-func (lintIdenticalBranches) identicalBranches(branches []*ast.BlockStmt) bool {
+func (w lintIdenticalBranches) identicalBranches(branches []*ast.BlockStmt) bool {
 	if len(branches) < 2 {
 		return false
 	}

diff --git a/rule/if-return.go b/rule/if-return.go
@@ -12,7 +12,7 @@ import (
 type IfReturnRule struct{}
 
 // Apply applies the rule to given file.
-func (*IfReturnRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *IfReturnRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -26,7 +26,7 @@ func (*IfReturnRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 }
 
 // Name returns the rule name.
-func (*IfReturnRule) Name() string {
+func (r *IfReturnRule) Name() string {
 	return "if-return"
 }
 

diff --git a/rule/import-alias-naming.go b/rule/import-alias-naming.go
@@ -95,7 +95,7 @@ func (r *ImportAliasNamingRule) Apply(file *lint.File, arguments lint.Arguments)
 }
 
 // Name returns the rule name.
-func (*ImportAliasNamingRule) Name() string {
+func (r *ImportAliasNamingRule) Name() string {
 	return "import-alias-naming"
 }
 

diff --git a/rule/import-shadowing.go b/rule/import-shadowing.go
@@ -13,7 +13,7 @@ import (
 type ImportShadowingRule struct{}
 
 // Apply applies the rule to given file.
-func (*ImportShadowingRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *ImportShadowingRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	importNames := map[string]struct{}{}
@@ -38,7 +38,7 @@ func (*ImportShadowingRule) Apply(file *lint.File, _ lint.Arguments) []lint.Fail
 }
 
 // Name returns the rule name.
-func (*ImportShadowingRule) Name() string {
+func (r *ImportShadowingRule) Name() string {
 	return "import-shadowing"
 }
 

diff --git a/rule/imports-blacklist.go b/rule/imports-blacklist.go
@@ -68,6 +68,6 @@ func (r *ImportsBlacklistRule) Apply(file *lint.File, arguments lint.Arguments)
 }
 
 // Name returns the rule name.
-func (*ImportsBlacklistRule) Name() string {
+func (r *ImportsBlacklistRule) Name() string {
 	return "imports-blacklist"
 }
diff --git a/rule/increment-decrement.go b/rule/increment-decrement.go
@@ -12,7 +12,7 @@ import (
 type IncrementDecrementRule struct{}
 
 // Apply applies the rule to given file.
-func (*IncrementDecrementRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *IncrementDecrementRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	fileAst := file.AST
@@ -29,7 +29,7 @@ func (*IncrementDecrementRule) Apply(file *lint.File, _ lint.Arguments) []lint.F
 }
 
 // Name returns the rule name.
-func (*IncrementDecrementRule) Name() string {
+func (r *IncrementDecrementRule) Name() string {
 	return "increment-decrement"
 }
 

diff --git a/rule/indent-error-flow.go b/rule/indent-error-flow.go
@@ -9,17 +9,17 @@ import (
 type IndentErrorFlowRule struct{}
 
 // Apply applies the rule to given file.
-func (e *IndentErrorFlowRule) Apply(file *lint.File, args lint.Arguments) []lint.Failure {
-	return ifelse.Apply(e, file.AST, ifelse.TargetElse, args)
+func (r *IndentErrorFlowRule) Apply(file *lint.File, args lint.Arguments) []lint.Failure {
+	return ifelse.Apply(r, file.AST, ifelse.TargetElse, args)
 }
 
 // Name returns the rule name.
-func (*IndentErrorFlowRule) Name() string {
+func (r *IndentErrorFlowRule) Name() string {
 	return "indent-error-flow"
 }
 
 // CheckIfElse evaluates the rule against an ifelse.Chain.
-func (*IndentErrorFlowRule) CheckIfElse(chain ifelse.Chain, args ifelse.Args) (failMsg string) {
+func (r *IndentErrorFlowRule) CheckIfElse(chain ifelse.Chain, args ifelse.Args) (failMsg string) {
 	if !chain.If.Deviates() {
 		// this rule only applies if the if-block deviates control flow
 		return

diff --git a/rule/line-length-limit.go b/rule/line-length-limit.go
@@ -58,7 +58,7 @@ func (r *LineLengthLimitRule) Apply(file *lint.File, arguments lint.Arguments) [
 }
 
 // Name returns the rule name.
-func (*LineLengthLimitRule) Name() string {
+func (r *LineLengthLimitRule) Name() string {
 	return "line-length-limit"
 }
 

diff --git a/rule/max-public-structs.go b/rule/max-public-structs.go
@@ -65,7 +65,7 @@ func (r *MaxPublicStructsRule) Apply(file *lint.File, arguments lint.Arguments)
 }
 
 // Name returns the rule name.
-func (*MaxPublicStructsRule) Name() string {
+func (r *MaxPublicStructsRule) Name() string {
 	return "max-public-structs"
 }
 

diff --git a/rule/modifies-param.go b/rule/modifies-param.go
@@ -11,7 +11,7 @@ import (
 type ModifiesParamRule struct{}
 
 // Apply applies the rule to given file.
-func (*ModifiesParamRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *ModifiesParamRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -24,7 +24,7 @@ func (*ModifiesParamRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failur
 }
 
 // Name returns the rule name.
-func (*ModifiesParamRule) Name() string {
+func (r *ModifiesParamRule) Name() string {
 	return "modifies-parameter"
 }
 

diff --git a/rule/modifies-value-receiver.go b/rule/modifies-value-receiver.go
@@ -11,7 +11,7 @@ import (
 type ModifiesValRecRule struct{}
 
 // Apply applies the rule to given file.
-func (*ModifiesValRecRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *ModifiesValRecRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -26,7 +26,7 @@ func (*ModifiesValRecRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failu
 }
 
 // Name returns the rule name.
-func (*ModifiesValRecRule) Name() string {
+func (r *ModifiesValRecRule) Name() string {
 	return "modifies-value-receiver"
 }
 
@@ -119,7 +119,7 @@ func (w lintModifiesValRecRule) skipType(t ast.Expr) bool {
 	return strings.HasPrefix(rtName, "[]") || strings.HasPrefix(rtName, "map[")
 }
 
-func (lintModifiesValRecRule) getNameFromExpr(ie ast.Expr) string {
+func (w lintModifiesValRecRule) getNameFromExpr(ie ast.Expr) string {
 	ident, ok := ie.(*ast.Ident)
 	if !ok {
 		return ""

diff --git a/rule/nested-structs.go b/rule/nested-structs.go
@@ -10,7 +10,7 @@ import (
 type NestedStructs struct{}
 
 // Apply applies the rule to given file.
-func (*NestedStructs) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *NestedStructs) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	walker := &lintNestedStructs{
@@ -25,7 +25,7 @@ func (*NestedStructs) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 }
 
 // Name returns the rule name.
-func (*NestedStructs) Name() string {
+func (r *NestedStructs) Name() string {
 	return "nested-structs"
 }
 

diff --git a/rule/optimize-operands-order.go b/rule/optimize-operands-order.go
@@ -12,7 +12,7 @@ import (
 type OptimizeOperandsOrderRule struct{}
 
 // Apply applies the rule to given file.
-func (*OptimizeOperandsOrderRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *OptimizeOperandsOrderRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -26,7 +26,7 @@ func (*OptimizeOperandsOrderRule) Apply(file *lint.File, _ lint.Arguments) []lin
 }
 
 // Name returns the rule name.
-func (*OptimizeOperandsOrderRule) Name() string {
+func (r *OptimizeOperandsOrderRule) Name() string {
 	return "optimize-operands-order"
 }
 

diff --git a/rule/package-comments.go b/rule/package-comments.go
@@ -38,7 +38,7 @@ func (r *PackageCommentsRule) Apply(file *lint.File, _ lint.Arguments) []lint.Fa
 }
 
 // Name returns the rule name.
-func (*PackageCommentsRule) Name() string {
+func (r *PackageCommentsRule) Name() string {
 	return "package-comments"
 }
 

diff --git a/rule/range-val-address.go b/rule/range-val-address.go
@@ -13,7 +13,7 @@ import (
 type RangeValAddress struct{}
 
 // Apply applies the rule to given file.
-func (*RangeValAddress) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *RangeValAddress) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	walker := rangeValAddress{
@@ -30,7 +30,7 @@ func (*RangeValAddress) Apply(file *lint.File, _ lint.Arguments) []lint.Failure
 }
 
 // Name returns the rule name.
-func (*RangeValAddress) Name() string {
+func (r *RangeValAddress) Name() string {
 	return "range-val-address"
 }
 

diff --git a/rule/range-val-in-closure.go b/rule/range-val-in-closure.go
@@ -11,7 +11,7 @@ import (
 type RangeValInClosureRule struct{}
 
 // Apply applies the rule to given file.
-func (*RangeValInClosureRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *RangeValInClosureRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	walker := rangeValInClosure{
@@ -26,7 +26,7 @@ func (*RangeValInClosureRule) Apply(file *lint.File, _ lint.Arguments) []lint.Fa
 }
 
 // Name returns the rule name.
-func (*RangeValInClosureRule) Name() string {
+func (r *RangeValInClosureRule) Name() string {
 	return "range-val-in-closure"
 }
 

diff --git a/rule/range.go b/rule/range.go
@@ -12,7 +12,7 @@ import (
 type RangeRule struct{}
 
 // Apply applies the rule to given file.
-func (*RangeRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *RangeRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -25,7 +25,7 @@ func (*RangeRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 }
 
 // Name returns the rule name.
-func (*RangeRule) Name() string {
+func (r *RangeRule) Name() string {
 	return "range"
 }
 

diff --git a/rule/receiver-naming.go b/rule/receiver-naming.go
@@ -12,7 +12,7 @@ import (
 type ReceiverNamingRule struct{}
 
 // Apply applies the rule to given file.
-func (*ReceiverNamingRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *ReceiverNamingRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	fileAst := file.AST
@@ -29,7 +29,7 @@ func (*ReceiverNamingRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failu
 }
 
 // Name returns the rule name.
-func (*ReceiverNamingRule) Name() string {
+func (r *ReceiverNamingRule) Name() string {
 	return "receiver-naming"
 }
 

diff --git a/rule/redefines-builtin-id.go b/rule/redefines-builtin-id.go
@@ -61,7 +61,7 @@ var builtInTypes = map[string]bool{
 type RedefinesBuiltinIDRule struct{}
 
 // Apply applies the rule to given file.
-func (*RedefinesBuiltinIDRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *RedefinesBuiltinIDRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	onFailure := func(failure lint.Failure) {
@@ -76,7 +76,7 @@ func (*RedefinesBuiltinIDRule) Apply(file *lint.File, _ lint.Arguments) []lint.F
 }
 
 // Name returns the rule name.
-func (*RedefinesBuiltinIDRule) Name() string {
+func (r *RedefinesBuiltinIDRule) Name() string {
 	return "redefines-builtin-id"
 }
 
@@ -162,7 +162,7 @@ func (w lintRedefinesBuiltinID) addFailure(node ast.Node, msg string) {
 	})
 }
 
-func (lintRedefinesBuiltinID) isBuiltIn(id string) (r bool, builtInKind string) {
+func (w lintRedefinesBuiltinID) isBuiltIn(id string) (r bool, builtInKind string) {
 	if builtFunctions[id] {
 		return true, "function"
 	}

diff --git a/rule/redundant-import-alias.go b/rule/redundant-import-alias.go
@@ -12,7 +12,7 @@ import (
 type RedundantImportAlias struct{}
 
 // Apply applies the rule to given file.
-func (*RedundantImportAlias) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
+func (r *RedundantImportAlias) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	for _, imp := range file.AST.Imports {
@@ -34,7 +34,7 @@ func (*RedundantImportAlias) Apply(file *lint.File, _ lint.Arguments) []lint.Fai
 }
 
 // Name returns the rule name.
-func (*RedundantImportAlias) Name() string {
+func (r *RedundantImportAlias) Name() string {
 	return "redundant-import-alias"
 }