Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP option "End of options" might not coincide with header len #539

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IP option "End of options" might not coincide with header len #539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eab1740
IP option "End of options" might not coincide with header len
yagel-dev Oct 9, 2024
63d4d0e
Fix formatting
yagel-dev Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ IP::IP(const uint8_t* buffer, uint32_t total_sz) {
else if (opt_type == END) {
// If the end option found, we're done
if (TINS_UNLIKELY(stream.pointer() != options_end)) {
// Make sure we found the END option at the end of the options list
throw malformed_packet();
// Skip to the end of the options list
stream.skip(options_end - stream.pointer());
}
break;
}
Expand Down