Don't throw exception for empty interface #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had an odd issue on my openwrt router. my libtins app would worked fine until installing
netem
e.g.opkg install kmod-netem
which depends onkmod-sched
. After installing that, a new empty interface is created (at least on openwrt, not sure about other distros) that has no IP address.I see no reason to throw an exception here. It is especially problematic because at least in my app, the interfaces are initialized when the program starts, I suppose in a constructor somewhere.
Simply removing this solves the issue. Perhaps a better approach would be to only throw an exception when a given interface is empty and chosen for us with a sniffer. I'm not exactly sure how
kmod-sched
uses the empty interface, but it may even be desirable to monitor such an interface.In short.. I believe this check should be deleted or at least turned into something that doesnt abort a program.