Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process more 802.11 options #298

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Process more 802.11 options #298

wants to merge 3 commits into from

Conversation

RangelReale
Copy link

  • HT capability (45)
  • VHT capability (191)
  • EXT capability (127)

mfontanini
mfontanini reviewed May 25, 2018
View reviewed changes
include/tins/sniffer.h Outdated
@@ -673,7 +673,7 @@ void Tins::BaseSniffer::sniff_loop(Functor function, uint32_t max_packets) {
for(iterator it = begin(); it != end(); ++it) {
try {
// If the functor returns false, we're done
#if TINS_IS_CXX11 && !defined(_MSC_VER)
#if TINS_IS_CXX11 && defined(TINS_IS_CXX11_MSVCCOMPAT)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this was added a while back when VC's support for C++11 was still not great.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's tabs here, could you use spaces?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfontanini mfontanini mfontanini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RangelReale @mfontanini