Fixed several bugs

mfkrause · Jan 22, 2021 · 247038f · 247038f
1 parent eca184d
commit 247038f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/base/accessory.js b/base/accessory.js
@@ -31,11 +31,6 @@ class SunsensorAccessory {
 
     if (SensorService) {
       SensorService.getCharacteristic(Characteristic.OccupancyDetected);
-
-      SensorService.setCharacteristic(Characteristic.OccupancyDetected, this.updateState());
-      setInterval(() => {
-        SensorService.setCharacteristic(Characteristic.OccupancyDetected, this.updateState());
-      }, 10000);
     }
 
     this.setAccessory(accessory);
@@ -61,6 +56,11 @@ class SunsensorAccessory {
       SensorService
         .getCharacteristic(Characteristic.OccupancyDetected)
         .on('get', this.getState.bind(this));
+
+      SensorService.setCharacteristic(Characteristic.OccupancyDetected, this.updateState());
+      setInterval(() => {
+        SensorService.setCharacteristic(Characteristic.OccupancyDetected, this.updateState());
+      }, 10000);
     }
   }
 

diff --git a/base/platform.js b/base/platform.js
@@ -50,8 +50,8 @@ class SunsensorPlatform {
           (sensor) => sensor.name === accessory.displayName,
         );
         if (
-          !sensorConfig.lowerThreshold
-          || !sensorConfig.upperThreshold
+          sensorConfig.lowerThreshold === undefined
+          || sensorConfig.upperThreshold === undefined
           || typeof sensorConfig.lowerThreshold !== 'number'
           || typeof sensorConfig.upperThreshold !== 'number'
           || sensorConfig.lowerThreshold > 720
@@ -65,6 +65,8 @@ class SunsensorPlatform {
             log('Could not unregister platform accessory!', e);
           }
         } else {
+          const sensor = this.sensors[sensorConfig.name];
+          sensor.setAccessory(accessory);
           tempAccessories.push(accessory);
         }
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "homebridge-sunsensors",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Homebridge plugin to set-up sensors which monitor the current sun position.",
   "main": "index.js",
   "scripts": {