Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing installation page and updates quick start #48

Merged

Conversation

froschdesign
Copy link
Member

No description provided.

@froschdesign froschdesign added Bug Something isn't working Documentation labels Jan 12, 2024
@froschdesign froschdesign added this to the 1.13.1 milestone Jan 12, 2024
@froschdesign
Copy link
Member Author

The DOCS_DEPLOY_KEY is the legacy key and must be replaced:

# check values
remote_repo=""
if [ -n "${DEPLOY_TOKEN}" ]; then
    remote_repo_setup remote_repo "${DEPLOY_TOKEN}"
else
    if [ -n "${DOCS_DEPLOY_KEY}" ]; then
        remote_repo_setup_legacy remote_repo "${DOCS_DEPLOY_KEY}"
    else
        print_error "Neither DEPLOY_TOKEN nor DOCS_DEPLOY_KEY found; please provide one or the other in your workflow env"
        kill -s KILL $TOP_PID
    fi
fi

https://github.com/laminas/documentation-theme/blob/c9c95a899460735dc06ccff05ec47d1c4f95e8ba/github-actions/docs/entrypoint.sh#L64-L75

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

…omatically added via a script

Signed-off-by: Frank Brückner <[email protected]>
@gsteel
Copy link
Member

gsteel commented Jan 18, 2024

Test failures on latest here are fixed in 1.14.x in 3bb0704 - The failures concern changes to how PHPUnit deals with set_error_handler so it should be fine to release this patch - it'll go green when merged up to 1.14.x

@froschdesign froschdesign merged commit b8b75be into mezzio:1.13.x Jan 18, 2024
11 of 14 checks passed
@froschdesign froschdesign deleted the hotfix/docs/missing-installation-page branch January 18, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants