Tests data for maximum over a height coordinate #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MoseleyS
requested changes
Oct 3, 2023
There was a problem hiding this comment.
These new files have been copied directly from StaGE (probably at my suggestion). As such, they contain a number of attributes that the metadata interpreter is objecting to. Please can you use the improver standardise CLI to remove them.
ValueError: Attributes dict_keys(['history', 'institution', 'mosg__forecast_run_duration', 'mosg__grid_domain', 'mosg__grid_type', 'mosg__grid_version', 'mosg__model_configuration', 'source', 'title', 'um_version', 'Conventions']) include one or more forbidden values ['mosg__forecast_run_duration', 'mosg__grid_domain', 'mosg__grid_type', 'mosg__grid_version', 'um_version']
MoseleyS
approved these changes
Oct 5, 2023
brhooper
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: metoppv/improver#1945
Plots of new data
input.nc
kgo_with_bounds.nc
kgo_without_bounds.nc