-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the lightning_flash_accumulation_in_vicinity cell method missing from imengluk #2064
added the lightning_flash_accumulation_in_vicinity cell method missing from imengluk #2064
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2064 +/- ##
========================================
Coverage 98.39% 98.40%
========================================
Files 124 134 +10
Lines 12212 13140 +928
========================================
+ Hits 12016 12930 +914
- Misses 196 210 +14 ☔ View full report in Codecov by Sentry. |
…t pre-commits failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed your code, it is looking good and I can't see any changes that need to be made. I will put it into second review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maxwhitemet, these changes look as I expected them to.
I've attempted to run all of the IMPROVER tests and get failures for acceptance tests in improver_tests/acceptance/test_lightning_from_cape_and_precip.py
. I think that the KGOs for these tests need updating to include the new cell method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maxwhitemet, this all looks fine to me.
I think you'll need to pull master back into this branch before it can be merged, so that the fix to the Github actions can be included.
…to resolve Github action failures folowing known bug fix
Addresses #802
Testing: