Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the lightning_flash_accumulation_in_vicinity cell method missing from imengluk #2064

Conversation

maxwhitemet
Copy link
Contributor

Addresses #802

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (84a8944) to head (41b7f5c).
Report is 54 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2064    +/-   ##
========================================
  Coverage   98.39%   98.40%            
========================================
  Files         124      134    +10     
  Lines       12212    13140   +928     
========================================
+ Hits        12016    12930   +914     
- Misses        196      210    +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxwhitemet maxwhitemet reopened this Dec 10, 2024
@maxwhitemet maxwhitemet changed the title added the lightning_flash_accumulation_in_vicinity cell method missing from added the lightning_flash_accumulation_in_vicinity cell method missing from imengluk Dec 10, 2024
@maxwhitemet maxwhitemet marked this pull request as ready for review December 10, 2024 17:29
Copy link
Contributor

@lambert-p lambert-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code, it is looking good and I can't see any changes that need to be made. I will put it into second review.

Copy link
Contributor

@brhooper brhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxwhitemet, these changes look as I expected them to.

I've attempted to run all of the IMPROVER tests and get failures for acceptance tests in improver_tests/acceptance/test_lightning_from_cape_and_precip.py. I think that the KGOs for these tests need updating to include the new cell method.

Copy link
Contributor

@brhooper brhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxwhitemet, this all looks fine to me.

I think you'll need to pull master back into this branch before it can be merged, so that the fix to the Github actions can be included.

…to resolve Github action failures folowing known bug fix
@maxwhitemet maxwhitemet merged commit 6906543 into metoppv:master Dec 18, 2024
10 checks passed
@maxwhitemet maxwhitemet deleted the mobt802_lightning_cell_method_consistency branch December 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants