Enforce consistent altitude, latitude and longitude for site EMOS #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longitude columns have the same, consistent value for a given site. This will prevent issues when these columns are used when creating a cube and mismatching values will prevent cubes being merged successfully.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1951 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 123 123
Lines 11792 11800 +8
=======================================
+ Hits 11602 11610 +8
Misses 190 190
☔ View full report in Codecov by Sentry. |
bayliffe
approved these changes
Oct 5, 2023
MoseleyS
approved these changes
Oct 5, 2023
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
… longitude columns have the same, consistent value for a given site. This will prevent issues when these columns are used when creating a cube and mismatching values will prevent cubes being merged successfully. (metoppv#1951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/570
Add function and unit tests to ensure that the altitude, latitude and longitude columns have the same, consistent value for a given site. This will ensure that site EMOS is robust to updates to the altitude, latitude and longitude that may occur if corrections are made to the position of the sites.
Testing: