WIP: Wind direction modifications #1947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simpler method takes about 65% the CPU time as the original method (tested on a massive array of angles). Furthermore, the original method introduces a tiny error for a very few angles near 0/360 degrees.
We blend wind direction data using the IMPROVER wind direction functionality. We identify wind direction data by it having units of degrees. This identification of wind directions could be generalised to any variabe which has units that can be converted to degrees, not just degrees. For example, if the units were radians. But I've not seen things like radians used in meteorology, so just restricting the code to variables with units of "degrees" is OK for now.
This was introduced by me at the previous commit.
Test 1: 350->20 degrees, expect 5 degrees. Test 2: 40->60 degrees, expect 50 degrees.
We assume that wind directions can be identified by the units attribute being "degrees". If this is the case, we use the special wind direction blending functionality to handle blending.
Initially we had direction blending in the wrong function. It worked, as long as that function was called. If it wasn't then direction blending didn't happen.
thbom001
added
the
BoM review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #GitHubissuenum
Description
Testing:
CLA