fix bad content-type in captcha response #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some undiscovered cases, the content-type of the captcha-page will be text/plain instead of text/html. a blank new meteor-project with sikka doesn't send the captcha-page in text/html, but unfortunately my more complex meteor-app does. I don't know why, but the response content-type in line 42 seems to be wrong. It should be 'text/html' not 'html'. Changing this fixed the problem for me.
|
This pull-request was necessary for me to use Sikka as well. I think it should be merged. |
|
Pinging @arunoda since there haven't been updates to this repo/pull-request for a while. |
|
@arunoda I have the same issue. |
|
I was going to make a PR for the same change but realized I forgot to check if someone had done it first. Thanks! |
|
Maybe the https://github.com/xunga/sikka-CM fork would be better to use, since it's been updated more than this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some undiscovered cases, the content-type of the captcha-page will be text/plain instead of text/html.
a blank new meteor-project with sikka doesn't send the captcha-page in text/html, but unfortunately my more complex meteor-app does. I don't know why, but the response content-type in line 42 seems to be wrong. It should be 'text/html' not 'html'. Changing this fixed the problem for me.