parser: allow numeric literals as object keys

Refs: https://github.com/metarhia/jstp/issues/152 PR-URL: metarhia/jstp#223 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Dmytro Nechai <[email protected]>
metarhia · Jun 20, 2017 · 62a4e1e · 62a4e1e
1 parent 9c7c4c7
commit 62a4e1e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/jsrs_parser.cc b/src/jsrs_parser.cc
@@ -721,6 +721,7 @@ MaybeLocal<Value> ParseObject(Isolate*    isolate,
   bool key_mode = true;
   *size = end - begin;
   MaybeLocal<String> current_key;
+  MaybeLocal<Value> current_numeric_key;
   MaybeLocal<Value> current_value;
   size_t current_length = 0;
   auto result = Object::New(isolate);
@@ -734,10 +735,16 @@ MaybeLocal<Value> ParseObject(Isolate*    isolate,
         has_ended = true;
         break;
       }
-      current_key = ParseKeyInObject(isolate,
-                                     begin + i,
-                                     end,
-                                     &current_length);
+      if (!isdigit(begin[i])) {
+        current_key = ParseKeyInObject(isolate, begin + i, end,
+            &current_length);
+      } else {
+        current_numeric_key = ParseNumber(isolate, begin + i, end,
+            &current_length);
+        current_key = current_numeric_key.IsEmpty() ? MaybeLocal<String>() :
+            current_numeric_key.ToLocalChecked()->ToString(
+                isolate->GetCurrentContext());
+      }
       if (current_key.IsEmpty()) {
         return MaybeLocal<Value>();
       }

diff --git a/test/fixtures/json5/objects/numeric-literal-key.json5 b/test/fixtures/json5/objects/numeric-literal-key.json5
@@ -0,0 +1,3 @@
+{
+    42: true
+}