Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix m1 pipeline #475

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Fix m1 pipeline #475

merged 5 commits into from
Mar 20, 2024

Conversation

MarkSackerberg
Copy link
Contributor

Currently no binary for m1 is created. The macos 14 runner is based on m1. By adding it it should be created.

@samuelvanderwaal
Copy link
Contributor

Nice. This wasn't available when we set up the CI initially.

@MarkSackerberg
Copy link
Contributor Author

So my assumption that the m1 binary was generated locally in the past is correct @samuelvanderwaal?

Happy to PR the same minor change into metaboss if that's the case.

@samuelvanderwaal
Copy link
Contributor

So my assumption that the m1 binary was generated locally in the past is correct @samuelvanderwaal?

Yeah, we had to manually build on a M1 and upload the binary to the release assets.

Happy to PR the same minor change into metaboss if that's the case.

I just did. 😁

@MarkSackerberg MarkSackerberg merged commit 64fb1f6 into main Mar 20, 2024
4 checks passed
@MarkSackerberg MarkSackerberg deleted the fix/m1 branch March 20, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants