[MET-44]rocks gap filler server #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
force-pushed
the
feature/rocks-gap-filler-server
branch
2 times, most recently
from
6d40393
to
b285204
Compare
n00m4d
reviewed
Dec 26, 2023
| let (tx, rx) = tokio::sync::mpsc::channel(32); | ||
| let backend = self.slot_asset_idx.backend.clone(); | ||
|
|
||
| tokio::spawn(async move { |
There was a problem hiding this comment.
If I'm not mistaken our graceful stop is not propagating onto this one task because in main.rs we have JoinSet to handle all the tasks(workers) and here we create new JoinHandle by calling tokio::spawn and do not process it anyhow. So if we need graceful stop for this operation I think we have to use JoinSet which we are defining in main.rs file
There was a problem hiding this comment.
Presumably fixed it, please have another look and verify the approach.
n00m4d
approved these changes
Dec 26, 2023
StanChe
force-pushed
the
feature/rocks-gap-filler-server
branch
from
3f4da7c
to
542a759
Compare
RequescoS
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the asset streaming service for rocksdb.