feat: determinate gape slot range #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n00m4d
approved these changes
Dec 22, 2023
nft_ingester/src/message_handler.rs
Outdated
|
|
||
| async fn handle_account(&self, data: Vec<u8>) -> Result<(), IngesterError> { | ||
| let account_update = | ||
| utils::flatbuffer::account_info_generated::account_info::root_as_account_info(&data)?; | ||
|
|
||
| self.store_first_processed_slot(account_update.slot()); |
There was a problem hiding this comment.
LGTM!
But I would also consider extract first processed slot in a little bit different way, I mean that function will do it's job only once but then will be called with every new account update. We could get last saved slot as we do it now, and then once we got new update iter from that slot and get the next one, it will be our first processed slot. Isn't call to action, just a food for thought.
StanChe
reviewed
Dec 26, 2023
| let cloned_rocks_storage = rocks_storage.clone(); | ||
| tasks.spawn(tokio::spawn(async move { | ||
| loop { | ||
| let slot = cloned_rocks_storage.last_saved_slot().unwrap().unwrap(); |
There was a problem hiding this comment.
why is it safe unwrapping here?
StanChe
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.