-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make root_vjp
public
#157
base: main
Are you sure you want to change the base?
feat: make root_vjp
public
#157
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 93.37% 93.36% -0.01%
==========================================
Files 71 72 +1
Lines 2684 2696 +12
==========================================
+ Hits 2506 2517 +11
- Misses 178 179 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more design for the vjp
API.
root_vjp
should return a function rather than the product result.- How do you ensure the
solution
argument is the root ofsolve_fn
? Seems that the user can pass arbitrary tensors to yourroot_vjp
API. - Need more design for
argnums
and argument binding. Need more investigation forfunctools.partial
support.
Description
make
root_vjp
public to usersTypes of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)