Less offset indirection [don't merge] #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leventov can you trim this down to only your commit? if we need to merge the druid-io branch into the 0.9.2-mmx one that should be ok to do |
…ry granularity / interval is coarser than data (i. e. segment) interval, that is typical for topN queries (BACKEND-319)
leventov
force-pushed
the
lessOffsetIndirection
branch
from
75ffb36 to
d030c08
Compare
|
@drcrallen done |
leventov
changed the title
|
However, I think such a performance change, if we are not 100% sure this is a positive change (in this case I'm not sure), shouldn't be merged and tested until we have really precise and stable instruments (perf metrics) to measure impact, because otherwise making such changes in the hope it will improve performance is just wandering in the fog. We don't have such metrics yet. I'm working on this. |
drcrallen
force-pushed
the
0.9.2-mmx
branch
2 times, most recently
from
5d8065b to
75a6be0
Compare
|
@leventov sorry, I made a mistake in 0.9.2-mmx and had to rewrite history (I pushed something there I shouldn't have), please rebase. Again, sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Druid tests are run and passed.
It also pulls some commits from druid upstream, happened after last checkout into 0.9.2-mmx branch.