This repository has been archived by the owner on Aug 14, 2022. It is now read-only.
choose message template format HTML/MarkDown #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaminek
changed the title
metalmatze
suggested changes
Sep 29, 2019
| @@ -117,6 +119,11 @@ func main() { | |||
| Default("/templates/default.tmpl"). | |||
| ExistingFilesVar(&config.templatesPaths) | |||
|
|
|||
| a.Flag("parse.mode", "The template formatting mode HTML/Markdown"). | |||
| Envar("TEMPLATE_FORMAT"). | |||
| Default(string(telebot.ModeHTML)). | |||
There was a problem hiding this comment.
Rather than introducing a direct dependency on telebot in the main.go, could we create both ParseHTML and ParseMarkdown in pkg/telegram.
There was a problem hiding this comment.
I used telebot.ParseMode because telebot.SendMessage() depends on it, we can do what you said above, but still, I need to cast the param in telebot.SendMessage() to telebot.ParseMode to be able to compile cf:
pkg/telegram/bot.go:320:85: cannot use b.parseMode (type ParseMode) as type telebot.ParseMode in field value
make: *** [build] Error 2
What do you think? casting casting still holds the dependancy anyway.
| @@ -66,6 +66,7 @@ type Bot struct { | |||
| logger log.Logger | |||
| revision string | |||
| startTime time.Time | |||
| parseMode telebot.ParseMode | |||
There was a problem hiding this comment.
Can we set this still to telebot.ModeHTML as this is the current default.
|
Nice feature, I would love to use it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR let the user choose the template message format between HTML and Markdown. The format can be submitted as a parameter
parse.modeor envTEMPLATE_FORMATThe docker image is available
rg.fr-par.scw.cloud/devel/alertmanager-bot:0.4.1for testing