Add mkdir support #2949
Merged
Add mkdir support #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thank you for taking a stab at it - I know it's still in draft, but need to remember that we try to maintain agent<>cli compatability, and the way we add new messages is by checking protocol version before using new message types (see |
facundopoblete
force-pushed
the
mkdir-support
branch
from
b201742 to
66dfea6
Compare
facundopoblete
force-pushed
the
mkdir-support
branch
from
66dfea6 to
f4ff3b9
Compare
facundopoblete
force-pushed
the
mkdir-support
branch
from
50db523 to
b30da07
Compare
facundopoblete
force-pushed
the
mkdir-support
branch
from
d220886 to
5aa542b
Compare
aviramha
reviewed
Dec 2, 2024
Razz4780
reviewed
Dec 2, 2024
|
Is this still WIP? (I see it's not marked as draft) |
Done. Sorry for the delay, I had to make some changes and I needed the CI to validate them. |
facundopoblete
commented
Dec 17, 2024
Razz4780
requested changes
Dec 18, 2024
Razz4780
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to forward the
mkdircommand to the agent