Deny unused dependencies #2843
Open
Deny unused dependencies #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviramha
reviewed
Oct 18, 2024
| @@ -56,8 +56,9 @@ categories = ["development-tools", "backend", "devtool"] | |||
| [workspace.dependencies] | |||
| actix-codec = "0.5" | |||
| bincode = { version = "2.0.0-rc.2", features = ["serde"] } | |||
| bytes = "1" | |||
| tokio = { version = "1" } | |||
| bytes = "1.7" | |||
There was a problem hiding this comment.
Why do we prefer to be specific?
There was a problem hiding this comment.
Hmm, not sure actually. Just my habit 😅
There was a problem hiding this comment.
I prefer the less specific, as we have lock anyway..
| @@ -18,7 +18,7 @@ workspace = true | |||
|
|
|||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| [target.'cfg(target_os = "linux")'.dependencies] | |||
| @@ -14,3 +15,13 @@ pub mod credentials; | |||
| pub mod error; | |||
| /// Public/Private key abstraction for serialization and deserialization | |||
| pub mod key_pair; | |||
|
|
|||
| mod deps_required_for_compilation { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.