Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more config file extensions #98

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

asinbow
Copy link
Contributor

@asinbow asinbow commented Aug 23, 2023

Support more extensions of mirrord config files according to the doc.

@aviramha
Copy link
Member

aviramha commented Aug 23, 2023

Hey @asinbow ! Thanks for this contribution.
We'd need a few more changes for other extensions to work, more specifically see the isTargetSet function which parses the configuration from the extension.
Having said that, we plan on changing the extension to use the cli to parse configurations, then we won't have any format specific (yaml,json,toml) in our extensions.
I think we'll put this on hold until we do the refactor, but if you'd like to support the isTargetSet for other formats we will accept it (just letting you know it might be in vain)

Pending on #99

@asinbow
Copy link
Contributor Author

asinbow commented Aug 24, 2023

Thanks @aviramha! Looking forward to the future change.

FYI the reason why I need support for YAML is I need to put some comments on configurable env variables.

feature:
env:
  override:
    # possible values: a, b, c
    MY_ENV: a

It would be helpful for my team members.

@aviramha
Copy link
Member

Hey, wanted to give you an update that we prioritized necessary work to get this merged! Sorry about the delay!

@aviramha aviramha enabled auto-merge September 20, 2023 15:36
@aviramha
Copy link
Member

Sorry for taking this long!

@aviramha aviramha added this pull request to the merge queue Sep 20, 2023
Merged via the queue into metalbear-co:main with commit 0d2e92a Sep 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants