-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass config env vars to mirrord verify-config. #181
Pass config env vars to mirrord verify-config. #181
Conversation
Disregard this, not an issue of this PR, it also happens on main, see #182
giant pile of logs (you've been warned)2023-10-17 14:32:43,065 [ 2] INFO - #c.i.i.AppStarter - ------------------------------------------------------ IDE STARTED ------------------------------------------------------ |
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordApi.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordApi.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordApi.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordBinaryManager.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Michał Smolarek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new TomcatExecutionListener
needs fixing too 🐈
...ts/idea/src/main/kotlin/com/metalbear/mirrord/products/idea/IdeaRunConfigurationExtension.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordProjectService.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the env vars are still not used, you use only one MirrordApi
instance. And it's created like MirrordApi(this, null)
(MirrordProjectService
definition)
...ts/idea/src/main/kotlin/com/metalbear/mirrord/products/idea/IdeaRunConfigurationExtension.kt
Outdated
Show resolved
Hide resolved
...ucts/tomcat/src/main/kotlin/com/metalbear/mirrord/products/tomcat/TomcatExecutionListener.kt
Outdated
Show resolved
Hide resolved
...ucts/tomcat/src/main/kotlin/com/metalbear/mirrord/products/tomcat/TomcatExecutionListener.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordApi.kt
Outdated
Show resolved
Hide resolved
…own) // actually use the env vars in MirrordApi
Passes the launch env vars section to
mirrord verify-config
, andmirrord
, resolving config options that were set as env vars.