Skip to content

Commit

Permalink
Fix typos in the e2e flow (#147)
Browse files Browse the repository at this point in the history
  • Loading branch information
infiniteregrets authored Sep 11, 2023
1 parent d00dca5 commit a6e0109
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/reusable_e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ jobs:
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
- name: checkout repository
if: ${{ !github.event.inputs.mirrord_release_branch }}
if: ${{ !inputs.mirrord_release_branch }}
uses: actions/checkout@v3

# mirrord_release_branch boolean when set, means we are on a release branch
# and hence we need to checkout into the last released tag of mirrord-intellij
- name: checkout into mirrord-intellij if mirrord_release_branch
if: ${{ github.event.inputs.mirrord_release_branch }}
if: ${{ inputs.mirrord_release_branch }}
uses: actions/checkout@v3
with:
repository: "metalbear-co/mirrord-intellij"

- name: checkout into the last released tag if mirrord_release_branch
if: ${{ github.event.inputs.mirrord_release_branch }}
if: ${{ inputs.mirrord_release_branch }}
run: |
git fetch --all --tags
git checkout tags/$(grep 'pluginVersion =' gradle.properties | cut -d '=' -f 2 | xargs)
Expand All @@ -66,18 +66,18 @@ jobs:
# we are on a release branch, so we need to download the mirrord binary from
# mirrord-artifacts and add it to the path
- name: download mirrord binary
if: ${{ github.event.inputs.mirrord_release_branch }}
if: ${{ inputs.mirrord_release_branch }}
uses: actions/download-artifact@v3
with:
name: mirrord-artifacts
- name: add downloaded mirrord to path
if: ${{ github.event.inputs.mirrord_release_branch }}
if: ${{ inputs.mirrord_release_branch }}
run: |
chmod u+x mirrord
echo "${GITHUB_WORKSPACE}" >> "$GITHUB_PATH"
- name: get the latest mirrord binary
if: ${{ !github.event.inputs.mirrord_release_branch }}
if: ${{ !inputs.mirrord_release_branch }}
run: |
curl -fsSL https://raw.githubusercontent.com/metalbear-co/mirrord/main/scripts/install.sh | bash
Expand Down
2 changes: 1 addition & 1 deletion changelog.d/+reusable-e2e.internal.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Create a reusable worflow for running e2e tests such that we maintain e2e in one place and can run tests on mirrord's release branch
Create a reusable worflow for running e2e tests such that we maintain e2e in one place and can run tests on mirrord's release branch.

0 comments on commit a6e0109

Please sign in to comment.