Move registry mirrors into certs.d directory.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing this from the conf.d directory, the plugin merge results in a weird state.
Gerrit91
changed the title
certs.d directory.
majst01
approved these changes
Aug 30, 2024
This was referenced Oct 30, 2024
|
@Gerrit91 documentation was not updated, see metal-stack/docs#224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing this from the conf.d directory, the plugin merge results in a weird state, potentially breaking existing mirror configurations.
The GNA init.sh explicitly includes the certs.d directory to respect the mirrors during initial pull:
We adapt the the containerd configuration from what Gardener will contain in future versions (probably v1.101), when Gardener is capable of configuring registry mirrors through the OSC API. We will then need to mutate the OSC with the GEPM and can remove these parts.
This PR also fixes the issue that the isolated cluster files were only added to the user data, so it was a one-shot thing and would never be reconciled again. This is now fixed and the node-agent consistently reconciles state.